Merged
Conversation
✅ Deploy Preview for devspace-docs canceled.
|
tukobadnyanoba
force-pushed
the
add-kind-support
branch
5 times, most recently
from
b8d31ed to
31c095c
Compare
FabianKramm
requested changes
Jun 7, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@tukobadnyanoba thanks for the PR! Please see my comments below
tukobadnyanoba
force-pushed
the
add-kind-support
branch
2 times, most recently
from
62f26e3 to
866e6fa
Compare
tukobadnyanoba
force-pushed
the
add-kind-support
branch
2 times, most recently
from
30bfb3a to
f4df667
Compare
tukobadnyanoba
force-pushed
the
add-kind-support
branch
from
f4df667 to
ba8b56b
Compare
FabianKramm
approved these changes
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace ...now loads local images to kind cluster in case it is the kind context.
What else do we need to know?